Hey Paul, Steve,
eg look at <https://github.com/S...
# supports
Shivanshu Raj Shrivastava
08/14/2023, 1:45 PMHey Paul, Steve,
eg look at https://github.com/SigNoz/charts/blob/main/charts/signoz/templates/otel-collector/deployment.yaml#L76 and the value is coming from https://github.com/SigNoz/charts/blob/main/charts/signoz/values.yaml#L1091-L1095, similarly https://github.com/SigNoz/charts/blob/main/charts/clickhouse/values.yaml#L160
And the same thing is happening for all the other components.
BUT this serves the purpose, since, once the helm charts are rendered, it creates the k8s objects and the images are pulled from respective registries. (docker.io/signoz/signoz-otel-collector, docker.io/clickhouse/clickhouse-server, etc)
Even if we modify the charts to default to global registry (if set) you won't be able to use
--set global.image.registry="<http://myregistry.com|myregistry.com>"<http://myregistry.com|myregistry.com>--set global.image.registry="<http://myregistry.com|myregistry.com>"s
Srikanth Chekuri
08/14/2023, 1:55 PMHey Paul, Steve,
no, the current helm charts are pretty much hardcoded.What Steve said works. The “hardcoded” values are not hardcoded but default. The registry name can always be overrided by
--set global.imageRegistry=...s
Shivanshu Raj Shrivastava
08/14/2023, 2:00 PMCorrect, but can it be used for pulling the container images?
I trying to change de registry of all containers using helm with the parameter:AFAIU, here the ask is if the registry can be changed for--set global.image.registry="<http://myregistry.com|myregistry.com>"
all containersglobal.image.registryShivanshu Raj Shrivastava
08/14/2023, 2:02 PMthough individual images can be tweaked as mentioned in the Readme
s
Srikanth Chekuri
08/14/2023, 2:03 PMs
Shivanshu Raj Shrivastava
08/14/2023, 2:07 PMthis has no effect since the global value defined here is not referenced anywhere in the charts.
s
Srikanth Chekuri
08/14/2023, 2:08 PMs
Shivanshu Raj Shrivastava
08/14/2023, 2:11 PMShivanshu Raj Shrivastava
08/14/2023, 2:13 PMand
_helpers.tpl.Values.otelCollector.imageShivanshu Raj Shrivastava
08/14/2023, 2:14 PMbut yes, it contains for others
Shivanshu Raj Shrivastava
08/14/2023, 2:14 PMotelCollector.images
Srikanth Chekuri
08/14/2023, 2:16 PMYeah, probably some places were missed, would you mind creating an issue in the charts repo?
s
Shivanshu Raj Shrivastava
08/14/2023, 2:16 PMSure, thanks for bearing up with me
Shivanshu Raj Shrivastava
08/14/2023, 2:20 PMfiled an issue here https://github.com/SigNoz/charts/issues/272
s
Srikanth Chekuri
08/14/2023, 2:22 PMthanks
s
Steve Sims
08/14/2023, 6:16 PMit seems like we are looking a different charts. The one I pulled from charts.signoz.io does have an entry in _helpers.tpl file defining the template symbol that is actually used in the otel-collector deployment.yaml
Steve Sims
08/14/2023, 6:17 PM{{- define "otelCollector.image" -}}
{{- $registryName := default .Values.otelCollector.image.registry .Values.global.imageRegistry -}}
{{- $repositoryName := .Values.otelCollector.image.repository -}}
{{- $tag := .Values.otelCollector.image.tag | toString -}}
{{- if $registryName -}}
{{- printf "%s/%s:%s" $registryName $repositoryName $tag -}}
{{- else -}}
{{- printf "%s:%s" $repositoryName $tag -}}
{{- end -}}
{{- end -}}
p
Prashant Shahi
09/25/2023, 6:32 AM@Shivanshu Raj Shrivastava As mentioned by @Steve Sims, we already have support for global registry.
Try using the following instead, it adds the custom registry for all images:
Copy code
--set global.imageRegistry="<http://myregistry.com|myregistry.com>"2 Views