is there a possibility to revisit this PR? <https://github.com/SigNoz/charts/pull/618> it decoupled ...
d
is there a possibility to revisit this PR? https://github.com/SigNoz/charts/pull/618 it decoupled the clickhouse installation and operator installation. there are cases where we already have clickhouse operator running so we do not want to redeploy it as part of the SigNoz's helm chart.
v
Hi @Dimitris Mavrommatis, Its a breaking change. We'll need to think of a simpler PR which serves the purpose and isnt this big of a change.
d
yup makes sense. I can make a PR myself just for my use-case then
v
While I understand that this shouldn't have been there in the first place, it's now a deep hole. We want to start getting out of it slowly.
d
yeah and now with the zookeeper bitnami helm chart going away there is going to be a breaking change soon for sure
v
We've already addressed that by bundling the chart as is.
🙌 1
d
you won't be able to update zookeeper I think though as the images from bitnami are custom-made and they won't be releasing them anymore though right?
v
Yeah that is an issue. Internally, we're trying to work on a full migration to clickhouse keeper. We don't want to keep supporting zookeeper.
d
oh nice; that would be great actually. I am literally only running zookeeper because of SigNoz because the migration expects it it seems
v
Yeah... We want to check all boxes first and come up with a easy-peasy guide to move everyone to
chkeeper
. For now, we will continue to support zookeeper
3.7.1
without any breaking change. Probably, a good time to address this operator+cr mixup would be along with that. We're not sure at this point and hence that PR is still open.
👍 1
d
I myself have been using the altinity's helm chart for operator and clickhouse instances (for production they have 2 different ones instead of one with everything inside). if you are not doing anything custom then the drop-in replacement should be good enough. made a backwards compatible PR to disable clickhouse operator when we want to https://github.com/SigNoz/charts/pull/730