Hi all, I am using Helmfile to deploy Signoz, when...
# contributing
h
Hi all, I am using Helmfile to deploy Signoz, when i need to export log to s3, the AWS AccessKey and SecretKey should be mapped as
additionalEnvs
as plain text, simple key:value as image 1. I'm checked helm template and add a small piece to allow add secret on k8s as env for secure on git, for example:
Copy code
additionalEnvs:
    AWS_ACCESS_KEY_ID: 
      valueFrom:
        secretKeyRef:
          name: aws-s3-credentials
          key: access-key
    AWS_SECRET_ACCESS_KEY:
      valueFrom:
        secretKeyRef:
          name: aws-s3-credentials
          key: secret-key
this change apply to:
Copy code
{{- range $key, $val := .Values.otelDeployment.additionalEnvs }}
            - name: {{ $key }}
              {{- if kindIs "map" $val }}
              {{- toYaml $val | nindent 14 }}
              {{- else }}
              value: {{ $val | toYaml }}
              {{- end }}
            {{- end }}
Please check and merge this PR: https://github.com/SigNoz/charts/pull/627
v
Hi @hoangfphus, I have requested changes on the PR.