https://signoz.io logo
#contributing-frontend
Title
# contributing-frontend
a

Anik

12/28/2021, 5:40 AM
(hi šŸ‘‹ new here) So I was trying to work on this issue (#564) The linked doc does inform how to make puppeteer work by installing the repo version of chrome, but the problem is to launch that, we need access to the launch args, which are probably in the source of the package added here in this PR (#508), without which puppeteer launches its downloaded version anyway. Now possible solutions are ā€¢ using GoogleChromeLabs/critters (no browser needed) instead of the above package, not sure if they are 1 to 1 in features though ā—¦ similar list of alternatives mentioned on the critters repo ā€¢ symlink repo chrome to the path where puppeteer chromium is downloaded (messy šŸ˜¬)
p

Pranay

12/28/2021, 5:45 AM
hey @User Welcome to SigNoz community šŸ‘‹ and thanks for the detailed note @User is the lead maintainer for frontend parts in SigNoz. He should be able to help you out
šŸ‘‹ 1
p

Palash Gupta

12/28/2021, 6:04 AM
Hi @User
Welcome to the community and thanks for taking up the issue
can you please assign the issue to yourself
not able to grab the username
a

Anik

12/28/2021, 6:09 AM
ah my github username is
sadn1ck
p

Palash Gupta

12/28/2021, 6:10 AM
I think critters is better than the
htmlcritical
as it is not using any browser
a

Anik

12/28/2021, 6:10 AM
yeah that's what I think too, installing puppeteer everytime will also increase build times
p

Palash Gupta

12/28/2021, 6:10 AM
can you please raise the pr for same... also do check the docker build is success-full and all the requirements are meet
a

Anik

12/28/2021, 6:11 AM
sure, will do
p

Palash Gupta

12/28/2021, 6:11 AM
awesome šŸ˜‰
@User
a

Anik

12/28/2021, 6:15 AM
Thank you šŸ˜„
So i tried both the plugins from the prev PR and after installing critters, neither are helping much with the first load for some reason This is what critters says during build
650B .... seems not much
Both transfer 930~ish KB first load cc @User
p

Palash Gupta

12/28/2021, 7:05 AM
Ok but see is js lazy loaded ?
a

Anik

12/28/2021, 7:12 AM
i think so? yes the scripts are deferred in the output
(also looks like critters is better for prerendered or static pages apparently)
@User
p

Palash Gupta

12/28/2021, 8:13 AM
thank for raising the pr @User
will check the pr
a

Anik

12/28/2021, 8:14 AM
yeah fixed the issue lol, missed the dupe keys
my bad šŸ˜…
2 Views