This message was deleted.
# contributings
Slackbot
06/09/2021, 3:46 PMThis message was deleted.
p
Pranay
06/09/2021, 4:16 PM
Ok. will check thais @User
👍 1
r
Raj Das
06/09/2021, 4:24 PMThanks, @User. I just set up the base structure. After that we can add code quality check, multi-arch docker build(ARM64) and many more in the github workflow
a
Ankit Nayan
06/25/2021, 6:13 PM
@User I added comments on the PR-173, just need to change
mastermain👍 1
Ankit Nayan
06/25/2021, 6:14 PM
I recommend you to have a look at https://github.com/PostHog/posthog/tree/master/.github/workflows and raise issues to include whichever seem fit for SigNoz.
👍 1
Ankit Nayan
06/25/2021, 6:15 PM
Good job BTW 🙌
🙌 1
r
Raj Das
06/25/2021, 6:23 PMThanks @User , I addressed your comments.
Raj Das
06/25/2021, 6:24 PMearlier I didn’t check that signoz default branch is main
Raj Das
06/25/2021, 6:27 PM@User Have you set the GitHub secrets. I have mentioned it in a README file
Raj Das
06/25/2021, 6:28 PMBuild failed due to this.
Raj Das
06/25/2021, 6:58 PMSorry @User, I missed a step in github workflow scripts. Here is the PR-https://github.com/SigNoz/signoz/pull/189
Tested in my forked repo- https://github.com/rajdas98/signoz/actions/runs/972402199
a
Ankit Nayan
06/25/2021, 7:16 PM
@User I still see some issues
r
Raj Das
06/25/2021, 7:56 PMGot the issue 😅. It won’t happen again. PR-https://github.com/SigNoz/signoz/pull/190
Raj Das
06/26/2021, 2:21 PM@Ankit Nayan One more request- Can you create a branch protection rule for the main branch and add these checks
• get_filters
• build-flattener
• build-frontend
• build-query-service
So that whenever anyone raises a PR it will be the trigger that workflow.
a
Ankit Nayan
06/26/2021, 3:38 PM
Done 👍
thankyou 1
3 Views