https://signoz.io logo
#contributing
Title
# contributing
r

Raj Das

06/09/2021, 3:46 PM
Hi! I have added CI pipeline using github workflow for query-service, frontend and flattener. PTAL- https://github.com/SigNoz/signoz/pull/173 cc: @User @User
p

Pranay

06/09/2021, 4:16 PM
Ok. will check thais @User
👍 1
r

Raj Das

06/09/2021, 4:24 PM
Thanks, @User. I just set up the base structure. After that we can add code quality check, multi-arch docker build(ARM64) and many more in the github workflow
a

Ankit Nayan

06/25/2021, 6:13 PM
@User I added comments on the PR-173, just need to change
master
branch everywhere to
main
. Rest seems as a good starting point. We can add more functionalities step by step.
👍 1
I recommend you to have a look at https://github.com/PostHog/posthog/tree/master/.github/workflows and raise issues to include whichever seem fit for SigNoz.
👍 1
Good job BTW 🙌
🙌 1
r

Raj Das

06/25/2021, 6:23 PM
Thanks @User , I addressed your comments.
earlier I didn’t check that signoz default branch is main
@User Have you set the GitHub secrets. I have mentioned it in a README file
Build failed due to this.
Sorry @User, I missed a step in github workflow scripts. Here is the PR-https://github.com/SigNoz/signoz/pull/189 Tested in my forked repo- https://github.com/rajdas98/signoz/actions/runs/972402199
a

Ankit Nayan

06/25/2021, 7:16 PM
@User I still see some issues
r

Raj Das

06/25/2021, 7:56 PM
Got the issue 😅. It won’t happen again. PR-https://github.com/SigNoz/signoz/pull/190
@User One more request- Can you create a branch protection rule for the main branch and add these checks • get_filters • build-flattener • build-frontend • build-query-service So that whenever anyone raises a PR it will be the trigger that workflow.
a

Ankit Nayan

06/26/2021, 3:38 PM
Done 👍
thankyou 1
3 Views