Hi all,
I'd like to see if I can work on <https://...
# contributings
Sai Chander
10/08/2024, 10:26 AMHi all,
I'd like to see if I can work on https://github.com/SigNoz/signoz/issues/5036.
Is there any instructions on how to get started?
v
Vishal Sharma
10/08/2024, 8:16 PM@Vikrant Gupta/ @Yunus M Should be able to help you here
v
Vikrant Gupta
10/09/2024, 5:12 AMthe issue is with scripts / css getting loaded on the fly over the internet. you can start by bundling those with the application itself so that we do not have any dependency over the internet access
s
Sai Chander
10/10/2024, 3:17 AMGot it. I'll try to raise a draft PR today for you to review
Sai Chander
10/10/2024, 5:00 AMCan I get test URL for this?
@Vishal Sharma @Vikrant Gupta
Sai Chander
10/10/2024, 5:20 AMSai Chander
10/10/2024, 5:27 AMI used my own self hosted environment URL for basic testing
v
Vikrant Gupta
10/10/2024, 5:30 AM@Sai Chander You would need to test it in an air gapped environment rather than any test environment URL. does your self hosted environment had internet access ?
s
Sai Chander
10/10/2024, 6:08 AMIt had internet access but I checked the network calls to validate this
Sai Chander
10/10/2024, 6:08 AMI can double verify once again today to list down any external calls that are being fired as a comment in the PR
Sai Chander
10/10/2024, 9:11 AMI have updated the PR description to include the domains that are still being called from the frontend code.
I'm not exactly sure if they are blocking calls or not but my intuition is they aren't blocking.
Since they are mostly for analytics, intercom and checking for updates.
7 Views