Can I get a review on <https://github.com/SigNoz/c...
# contributings
Shruti Mantri
07/13/2024, 9:35 AMCan I get a review on https://github.com/SigNoz/charts/pull/469 ?
cc: @Ashu
✅ 1
a
Ashu
07/14/2024, 8:30 AM
Thanks for the PR @Shruti Mantri. @Prashant Shahi has left a comment.
s
Shruti Mantri
07/14/2024, 8:35 AMReplied
p
Prashant Shahi
07/14/2024, 1:51 PMmy bad, I meant bump up patch version by one that is
24.1.3s
Shruti Mantri
07/14/2024, 1:53 PMok.. will do..
Shruti Mantri
07/14/2024, 1:54 PMdone
p
Prashant Shahi
07/14/2024, 1:55 PMJust the chart version, not the app version.
Prashant Shahi
07/14/2024, 1:55 PMApp version in clickhouse chart is the clickhouse version.
s
Shruti Mantri
07/14/2024, 1:55 PMohh.. ok
p
Prashant Shahi
07/14/2024, 1:56 PMCoincidently this time they seem to be similar 😅
s
Shruti Mantri
07/14/2024, 2:03 PMi thought they have to be same..