This message was deleted.

Slackbot

08/14/2023, 1:45 PM

This message was deleted.

Srikanth Chekuri

08/14/2023, 1:55 PM

Hey Paul, Steve,

no, the current helm charts are pretty much hardcoded.

What Steve said works. The “hardcoded” values are not hardcoded but default. The registry name can always be overrided by

--set global.imageRegistry=...

Shivanshu Raj Shrivastava

08/14/2023, 2:00 PM

Correct, but can it be used for pulling the container images?

I trying to change de registry of all containers using helm with the parameter:
--set global.image.registry="<http://myregistry.com|myregistry.com>"

AFAIU, here the ask is if the registry can be changed for

all containers

, but the answer is no, the rendered deployments are not referring to

global.image.registry

in values.yaml

Shivanshu Raj Shrivastava

08/14/2023, 2:02 PM

though individual images can be tweaked as mentioned in the Readme

Srikanth Chekuri

08/14/2023, 2:03 PM

https://github.com/SigNoz/charts/blob/main/charts/signoz/values.yaml#L4

Shivanshu Raj Shrivastava

08/14/2023, 2:07 PM

this has no effect since the global value defined here is not referenced anywhere in the charts.

Srikanth Chekuri

08/14/2023, 2:08 PM

https://github.com/search?q=repo%3ASigNoz%2Fcharts%20Values.global.imageRegistry&type=code

Shivanshu Raj Shrivastava

08/14/2023, 2:11 PM

I was referring to https://github.com/SigNoz/charts/blob/main/charts/signoz/templates/otel-collector/deployment.yaml#L76

Shivanshu Raj Shrivastava

08/14/2023, 2:13 PM

and

_helpers.tpl

does not contain a global default for

.Values.otelCollector.image

Shivanshu Raj Shrivastava

08/14/2023, 2:14 PM

but yes, it contains for others

Shivanshu Raj Shrivastava

08/14/2023, 2:14 PM

otelCollector.image

is the missing case, right?

Srikanth Chekuri

08/14/2023, 2:16 PM

Yeah, probably some places were missed, would you mind creating an issue in the charts repo?

Shivanshu Raj Shrivastava

08/14/2023, 2:16 PM

Sure, thanks for bearing up with me

👍 1

Shivanshu Raj Shrivastava

08/14/2023, 2:20 PM

filed an issue here https://github.com/SigNoz/charts/issues/272

Srikanth Chekuri

08/14/2023, 2:22 PM

thanks

🙂 1

Steve Sims

08/14/2023, 6:16 PM

it seems like we are looking a different charts. The one I pulled from charts.signoz.io does have an entry in _helpers.tpl file defining the template symbol that is actually used in the otel-collector deployment.yaml

Steve Sims

08/14/2023, 6:17 PM

{{- define "otelCollector.image" -}} {{- $registryName := default .Values.otelCollector.image.registry .Values.global.imageRegistry -}} {{- $repositoryName := .Values.otelCollector.image.repository -}} {{- $tag := .Values.otelCollector.image.tag | toString -}} {{- if $registryName -}} {{- printf "%s/%s:%s" $registryName $repositoryName $tag -}} {{- else -}} {{- printf "%s:%s" $repositoryName $tag -}} {{- end -}} {{- end -}}

Prashant Shahi

09/25/2023, 6:32 AM

@Shivanshu Raj Shrivastava As mentioned by @Steve Sims, we already have support for global registry. Try using the following instead, it adds the custom registry for all images:

Copy code

--set global.imageRegistry="<http://myregistry.com|myregistry.com>"

🆗 1

2 Views

Open in Slack

Previous Next

SigNoz Community

SigNoz is an open-source APM. It helps developers monitor their applications & troubleshoot problems, an open-source alternative to DataDog, NewRelic, etc.