OpentelemetryJs has changed - I make a new PR for ...
# generalh
Harald Fielker
03/17/2023, 2:04 PMOpentelemetryJs has changed - I make a new PR for the SigNoz examples and add some words of wisdom to it.
a
Ankit Nayan
03/17/2023, 2:07 PM
that would be helpful
h
Harald Fielker
03/17/2023, 2:08 PMThey changed the npm namespaces 10+ times - on npm there are still the old packages (just a warning, but nothing how/where/what to change)
Harald Fielker
03/17/2023, 2:08 PMthis is sick
s
Srikanth Chekuri
03/17/2023, 2:52 PMIt is still an evolving project and they should keep the old packages because someone might still be using them, this is done by every language group.
h
Harald Fielker
03/17/2023, 3:27 PMThat's not my point.
Harald Fielker
03/17/2023, 3:27 PMThe point is - the direction "please got to place X, replace A with B, include C, drop D" - that is 1000% missing.
Harald Fielker
03/17/2023, 3:28 PMIt took me one day to find that out and make an working example from the - broken - opentelemetry.JS example. Sorry - that's bad.
s
Srikanth Chekuri
03/17/2023, 3:32 PMThey publish upgrade guidelines https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines. While we don’t have control over that, we can get our examples up to date. Would really appreciate your contribution PR or just share the outdated repo or docs and we shall get it updated.
h
Harald Fielker
03/17/2023, 3:33 PMYes 🙂 they are 1000% useless
s
Srikanth Chekuri
03/17/2023, 3:34 PMThat’s harsh, if you think you could suggest something that makes it useful you can suggest and contribute to opentelemetry-js.
h
Harald Fielker
03/17/2023, 3:34 PMBad documentation is even worse then no documentation. Other npm projects (hey - it's npm!) get their sunsetting of an old package right - while opentelemetry didn't.
Harald Fielker
03/17/2023, 3:36 PMHarald Fielker
03/17/2023, 3:36 PM"Please use X"
Harald Fielker
03/17/2023, 3:37 PM(but what I didn't tell you - you need to - also replace x with y and use Class A instead of B. I don't tell you that in our upgradeguidelines, and I only put a broken example "somewhere" even didn't mentioning that we replaced npm packages)
Harald Fielker
03/17/2023, 3:37 PMstill to harsh?
Harald Fielker
03/17/2023, 3:38 PMalso bound instruments are gone (or might work totally different - I didn't find this out after one day)
s
Srikanth Chekuri
03/17/2023, 3:43 PMLet’s not argue over this and end it here; I get your frustration but there is another side to it. And we would really appreciate it if you can send a PR to update the SigNoz example or share which guide or repo you are referring following.
h
Harald Fielker
03/17/2023, 3:44 PMIt's me ranting about Opentelemetry JS not about SigNoz 🙂
s
Srikanth Chekuri
03/17/2023, 3:45 PMI understand and I am saying there is other side to it because I help a sub project (opentelemetry-python) and I know fellow maintainers struggles.
h
Harald Fielker
03/17/2023, 3:45 PMFun Fact. NodeJS killed the DDog Metrics library 1/2 year ago. DDog updated it - we didn't 😂
Harald Fielker
03/17/2023, 3:46 PMit was a tiny something about something with a Promise NodeJS changed and that broke the JS
Harald Fielker
03/17/2023, 4:29 PMs
Srikanth Chekuri
03/17/2023, 4:30 PMThank you
h
Harald Fielker
03/17/2023, 4:30 PMI squashed them - tell me if you need 3 PRs
s
Srikanth Chekuri
03/17/2023, 4:31 PMOne is fine
2 Views