signoz-community #github-activities

Join the conversation Join Slack

Channels

contributing

contributing-frontend

github-activities

GitHub

01/07/2023, 8:19 AM

#1995 Correlate Logs, Metrics and Traces in Single UI Issue created by spanhotra Hi Team, The tool is pretty neat and useful. I want to understand how I can have 3 components and correlate them together. My visualization strategy • From Traces, and drill into logs for the selected service and have it unified in one component. SigNoz/signoz

GitHub

01/07/2023, 12:52 PM

#1996 Release/v0.13.1 Pull request opened by prashant-shahi Signed-off-by: Prashant Shahi prashant@signoz.io SigNoz/signoz

GitHub

01/07/2023, 3:28 PM

Release - v0.13.1 New release published by ankitnayan What's Changed • Add Docs to install SQLite3 (#1924) @axaysagathiya • ci(deployments): workflows for staging and testing deployments and related changes (#1933) @prashant-shahi 🚀 Features • Removing Beta tag from Logs (#1952) @pranay01 🐛 Bug Fixes • fix: use rpc method and responseStatusCode (#1971) @makeavish • fix: Logs double api is called (#1947) @palashgdev • fix: disable button unless org name is different (#1984) @jyash97 • fix(sidebar): highlight active feature in nested route (#1929) @jyash97 • fix(logs): prevent duplicate logs dispatch (#1934) @jyash97 • ci: 👷 fix testing and staging deployments (#1980) @prashant-shahi • fix: 🐛 resolve redundant metrics issue in Docker and Swarm (#1946) @prashant-shahi • fix: apply filters on count of exceptions (#1945) @makeavish SigNoz/signoz

GitHub

01/07/2023, 6:43 PM

#1997 Irregular box sizes Issue created by UtkarshMishra12 Bug description Irregular box sizes Please describe. If this affects the front-end, screenshots would be of great help.

image▾

Expected behavior It should be equal in height How to reproduce Version information • Signoz version: • Browser version: • Your OS and version: • *Your CPU Architecture*(ARM/Intel): Additional context Thank you for your bug report – we love squashing them! SigNoz/signoz

GitHub

01/07/2023, 8:25 PM

#1998 [Snyk] Security upgrade react-vis from 1.11.7 to 1.11.8 Pull request opened by snyk-bot Snyk has created this PR to fix one or more vulnerable packages in the
yarn
dependencies of this project. Changes included in this PR • Changes to the following files to upgrade the vulnerable dependencies to a fixed version: • frontend/package.json • frontend/yarn.lock Vulnerabilities that will be fixed With an upgrade: (*) Note that the real score may have changed since the PR was raised. Check the changes in this PR to ensure they won't cause issues with your project. * * * Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs. For more information: https://camo.githubusercontent.com/b2cdde6548b3770f34bce9823b7737ca71ba2e12c1d84b67abf173393e1dbeeb/68747470733a2f2f6170692e7365676d656e742e696f2f76312f706978656c2f747261636b3f646174613d65794a33636d6c305a55746c65534936496e4a79576d785a634564485932527954485a7362306c596430645563566734576b4652546e4e434f5545774969776959573576626e6c746233567a535751694f694a684e7a64694f446b314e4330354d446b794c54517a4f4755744f5749314d5330774e574a6a4e5745345a544e684d6a6b694c434a6c646d567564434936496c425349485a705a58646c5a434973496e42796233426c636e52705a584d694f6e736963484a4a5a434936496d45334e3249344f5455304c546b774f5449744e444d345a533035596a55784c544131596d4d315954686c4d3245794f534a3966513d3d 🧐 View latest project report 🛠️ Adjust project settings 📚 Read more about Snyk's upgrade and patch logic * * * Learn how to fix vulnerabilities with free interactive lessons: 🦉 Regular Expression Denial of Service (ReDoS) SigNoz/signoz GitHub Actions: playwright GitHub Actions: lint-commits GitHub Actions: Ensure Pull Request has a linked issue. GitHub Actions: sonar-analysis ✅ 12 other checks have passed 12/16 successful checks

GitHub

01/07/2023, 11:22 PM

#2000 APM metrics show inaccurate values Issue created by srikanthccv The APM metrics show incorrect values when more than one collector instance is run. This is very important because, under high load, users will have multiple collector replicas. SigNoz/signoz

GitHub

01/08/2023, 6:40 AM

#2002 style: use Pull request opened by mariuskimmina SigNoz/signoz

GitHub

01/08/2023, 8:18 AM

#2003 fix(FE): show no No Data on default Dashboards Pull request opened by mariuskimmina Signed-off-by: Marius Kimmina mar.kimmina@gmail.com Closes #1908

image▾

SigNoz/signoz

GitHub

01/08/2023, 4:59 PM

2 new commits pushed to

<https://github.com/SigNoz/signoz/tree/develop|develop>

by ankitnayan

<https://github.com/SigNoz/signoz/commit/b35bdf01ccb30484f1bd56c3e2fe9d201cbd45ed|b35bdf01>

- chore: 📌 pin versions: SigNoz 0.13.1

<https://github.com/SigNoz/signoz/commit/435d74c37e0f429979243e4cab84986de08d2691|435d74c3>

- Merge pull request #1996 from SigNoz/release/v0.13.1 SigNoz/signoz

GitHub

01/08/2023, 5:00 PM

Deployment to staging by ankitnayan SigNoz/signoz

GitHub

01/08/2023, 5:42 PM

2 new commits pushed to

<https://github.com/SigNoz/signoz/tree/develop|develop>

by ankitnayan

<https://github.com/SigNoz/signoz/commit/0c27d5acbc13339b4d1e1c0f4333647ee8a13595|0c27d5ac>

- chore: better error handling

<https://github.com/SigNoz/signoz/commit/215ea8d8199af6fe6aec7b7d8c8f8ebc8c6994fa|215ea8d8>

- chore: different ticker interval for active user SigNoz/signoz

GitHub

01/08/2023, 5:43 PM

Deployment to staging by ankitnayan SigNoz/signoz

GitHub

01/08/2023, 6:34 PM

#2004 Don't show big loading icons in the panels when a dashboard reloads Issue created by ankitnayan ☑︎ #2073 ☑︎ #2074 ☑︎ #2075 SigNoz/signoz

GitHub

01/08/2023, 6:37 PM

#2005 Add lazy loading when showing all the panels in a dashboard Issue created by ankitnayan If a dashboard has 20 panels, we load (and hence the API calls) all the panels in one go. It fires 20 concurrent requests to clickhouse. We should add lazy loading here. We should only load the panels when a user scrolls down. SigNoz/signoz

GitHub

01/08/2023, 7:06 PM

1 new commit pushed to

<https://github.com/SigNoz/charts/tree/main|main>

by ankitnayan

<https://github.com/SigNoz/charts/commit/0757895c00312a56218c89d8f0de7a7b9f6f6ed1|0757895c>

- fix duplicate metrics issue in OtelCollectors of SigNoz and K8s-Infra charts (#125) SigNoz/charts

GitHub

01/08/2023, 7:06 PM

Release - signoz-0.7.1 New release published by github-actions[bot] SigNoz Observability Platform Helm Chart SigNoz/charts

GitHub

01/08/2023, 7:07 PM

Deployment to github-pages by github-pages[bot] SigNoz/charts

GitHub

01/09/2023, 7:56 AM

#2006 refactor: use antd form in organization display name Pull request opened by jyash97

image▾

SigNoz/signoz

GitHub

01/09/2023, 8:02 AM

#128 improve metrics and labels Pull request opened by prashant-shahi • snippet templates to include K8s and Otel envvars • attach more k8s labels using

relabel_config

• introduce

clusterName

configuration in both signoz and k8s-infra charts which is attached to telemetry data using resourcedection env • introduce

<http://apm.signoz.io/scrape|apm.signoz.io/scrape>

annotations for signoz apm spanmetrics • use

k8sattributes

processor in OtelCollector and

resourcedetection

processor from missing pipelines Note: After

resource_to_telemetry_conversion

issue is resolved, we could include

k8sattributes

resourcedetection

resource

processors in metrics pipeline. SigNoz/charts

GitHub

01/09/2023, 11:59 AM

#2007 Unable to view Services after installation of signoz Issue created by coding-dong Bug description Unable to view application after installation of signoz in the services section. Please describe. If this affects the front-end, screenshots would be of great help.

image▾

Expected behavior According to documentation once the installation is done... Applications would be shown in the services tab. How to reproduce 1. install signoz 2.open localhost:3301 2. check the services section Version information • Signoz version: 0.13.1 • Browser version: • Your OS and version: Linux localhost.localdomain 4.18.0-348.7.1.el8_5.x86_64 #1 SMP Wed Dec 22 13:25:12 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux • *Your CPU Architecture*(ARM/Intel): Additional context Thank you for your bug report – we love squashing them! SigNoz/signoz

GitHub

01/09/2023, 12:11 PM

#129 SigNoz chart values.yaml global.image.registry not respected Issue created by patrijua In SigNoz Helm chart values.yaml, there is a global setting of image registry global.image.registry but it is not working. Even though setting the value for global.image.registry when installing SigNoz chart, rendered chart contains still contains references to docker.io registy, for example: apiVersion: apps/v1 kind: StatefulSet metadata: name: signoz-query-service labels: helm.sh/chart: signoz-0.7.1 app.kubernetes.io/name: signoz app.kubernetes.io/instance: signoz app.kubernetes.io/component: query-service app.kubernetes.io/version: "0.13.0" app.kubernetes.io/managed-by: Helm spec: serviceName: signoz-query-service replicas: 1 selector: matchLabels: app.kubernetes.io/name: signoz app.kubernetes.io/instance: signoz app.kubernetes.io/component: query-service template: metadata: annotations: checksum/config: e9cdc72b583fd6c977f6942e4dc1f4c5749f6601cf147585de13ba210cf14e99 labels: app.kubernetes.io/name: signoz app.kubernetes.io/instance: signoz app.kubernetes.io/component: query-service spec: serviceAccountName: signoz-query-service securityContext: {} initContainers: - name: signoz-query-service-init image: docker.io/busybox:1.35 SigNoz/charts

GitHub

01/09/2023, 1:39 PM

#130 Invite links do not work if name is not given when creating the invite Issue created by patrijua When admin creates an invite link from Organization Settings view, the UI says that name is optional

image▾

When invite link is created and name is not given, when the user uses the link to create an account "Get Started" button is disabled and user can not create an account.

image▾

Observed with v0.12.0 and also v0.13.0 SigNoz/charts

GitHub

01/09/2023, 2:24 PM

#1999 fix: query builder formula fails to eval Pull request opened by srikanthccv on <!date^1673133293^{date_short}|2023-01-07T23:14:53Z> Fixes #1977 When there are more than two variables involved in a formula, the query should be formed by specifying the

ON

clause. Earlier query built:

SELECT 
  A.service_name as service_name, 
  A.ts as ts, 
  A.value / (B.value + C.value) as value 
FROM (
    ...
) as A JOIN (
    ...
) as B JOIN(
    ...
) as C USING (service, ts)

Correct query:

SELECT 
  A.service_name as service_name, 
  A.ts as ts, 
  A.value / (B.value + C.value) as value 
FROM (
    ...
) as A JOIN (
    ...
) as B ON A.service_name = B.service_name AND A.ts = B.ts JOIN(
    ...
) as C ON B.service_name = C.service_name AND B.ts = C.ts

SigNoz/signoz SonarCloud: Quality Gate failed GitHub Actions: playwright GitHub Actions: lint-commits ✅ 10 other checks have passed 10/13 successful checks

GitHub

01/09/2023, 2:34 PM

#2008 Invite links do not work if name is not given when creating the invite Issue created by patrijua Bug description Invite links do not work if name is not given when admin creates the invite. When invite link is created and name is NOT given, when the user uses the link to create an account "Get Started" button is remains disabled and user can not create an account. Expected behavior User should be able to create an account via invite link even thought admin did not provide name when creating the invite link How to reproduce 1. When admin creates an invite link from Organization Settings view, the UI says that name is optional. Admin creates the invite without giving the name

image▾

2.When invite link is created without name, when the user uses the link to create an account, "Get Started" button is disabled and user can not create an account

image▾

Version information v.0.12.0 v0.13.0 SigNoz/signoz

GitHub

01/09/2023, 5:05 PM

#131 Support `existingClaim` for `queryService.persistence` and `alertmanager.persistence` Issue created by sebastiaopamplona Hi, first of all I would just like to say that setting up SigNoz using helm was seamless :) However my cluster does not have

Dynamic Volume Provisioning

enabled. Hence I would like to ask if it's possible to support

existingClaim

queryService. persistence

and

alertmanager.persistence

, similar to how it is possible for

clickhouse.persistence

. The use case for this is that if for some reason I want to redeploy SigNoz on my cluster, I want to control which persistent volumes each service will get. Yesterday I was testing outage scenarios and came across the following situation: 1. Create 4 persistent volumes (pv1, pv2, pv3, pv4) 2. Deploy SigNoz 3. The query service persistent volume claim gets pv2 4. Register user 5. Remove SigNoz from the cluster 6. Deploy SigNoz again 7. The query service persistent volume claim gets pv3 8. The user registered in 4. is not found SigNoz/charts

GitHub

01/09/2023, 5:51 PM

Deployment to testing by ankitnayan SigNoz/signoz

GitHub

01/09/2023, 7:57 PM

#132 chore: :wrench: include relabel_configs and related prometheus changes Pull request opened by prashant-shahi Signed-off-by: Prashant Shahi prashant@signoz.io SigNoz/charts

GitHub

01/09/2023, 7:57 PM

#133 chore: :wrench: k8sattribute/resourceattribute processors Pull request opened by prashant-shahi Signed-off-by: Prashant Shahi prashant@signoz.io SigNoz/charts

GitHub

01/09/2023, 7:57 PM

#134 chore: :wrench: include clusterName and envvar templates Pull request opened by prashant-shahi Signed-off-by: Prashant Shahi prashant@signoz.io SigNoz/charts

GitHub

01/09/2023, 8:48 PM

#1611 Introduce exportman Pull request opened by webpro on <!date^1664950369^{date_short}|2022-10-05T06:12:49Z> Hi! Since your repo came up high in the GitHub Explore area when I was looking for a good TypeScript workload for exportman, I could just as well open a pull request with the results. It's a tool to help with repo maintenance by reporting unused files and exports. Here's what it reports in the

/frontend

folder with the configuration added in this pull request:

❯ exportman --config exportman.json --onlyFiles
--- UNUSED FILES (26)
src/container/EditRules/styles.ts
src/container/FormAlertChannels/Settings/LabelFilter.tsx
src/container/ListOfDashboard/dashboardSearchAndFilter.ts
src/container/NewDashboard/DashboardSettings/General/Description/index.tsx
src/container/NewDashboard/DashboardSettings/General/Description/styles.ts
src/container/NewDashboard/DescriptionOfDashboard/NameOfTheDashboard/index.tsx
src/container/Trace/Filters/Panel/PanelBody/styles.ts
src/container/Trace/Filters/styles.ts
src/hooks/useMountedState.ts
src/lib/JSXtoHTML.ts
src/lib/convertIntoHr.ts
src/lib/getGlobalDropDownFormatedDate.ts
src/lib/getSettingsPeroid.ts
src/pages/CreateAlert/styles.ts
src/store/actions/logs/addToSelectedField.ts
src/store/actions/trace/selectTraceFilter.ts
src/store/actions/trace/updateTagsSelected.ts
src/types/api/alerts/queryType.ts
src/types/api/dashboard/shared.ts
src/types/api/logs/operator.ts
src/types/api/logs/removeSelectedField.ts
src/types/api/user/setUserPreference.ts
src/typings/environment.ts
src/typings/window.ts
src/utils/fixtures/TraceData.ts
src/utils/token.ts

The results seem pretty accurate, but I'm not 100% sure about each file separately. For instance, I see some

styles.ts

files that are not imported anywhere, but they may be automatically included by a framework or build? If so, we can ignore such files and add them to the

filePatterns

with

!**/styles.ts

, and so on. Running the tool without the

--onlyFiles

flag will also report unused exports, unused types, and duplicate exports (didn't add them here for brevity). I believe this tool can help significantly when maintaining (and refactoring) repositories like this. Also see https://github.com/webpro/exportman if you're interested. Have a great day and best of luck with your project. SigNoz/signoz SonarCloud: Quality Gate failed GitHub Actions: build-frontend GitHub Actions: lint-commits GitHub Actions: Ensure Pull Request has a linked issue. GitHub Actions: Codeball GitHub Actions: playwright ✅ 6 other checks have passed 6/12 successful checks

Title

GitHub

01/09/2023, 8:48 PM

/frontend

folder with the configuration added in this pull request:

❯ exportman --config exportman.json --onlyFiles
--- UNUSED FILES (26)
src/container/EditRules/styles.ts
src/container/FormAlertChannels/Settings/LabelFilter.tsx
src/container/ListOfDashboard/dashboardSearchAndFilter.ts
src/container/NewDashboard/DashboardSettings/General/Description/index.tsx
src/container/NewDashboard/DashboardSettings/General/Description/styles.ts
src/container/NewDashboard/DescriptionOfDashboard/NameOfTheDashboard/index.tsx
src/container/Trace/Filters/Panel/PanelBody/styles.ts
src/container/Trace/Filters/styles.ts
src/hooks/useMountedState.ts
src/lib/JSXtoHTML.ts
src/lib/convertIntoHr.ts
src/lib/getGlobalDropDownFormatedDate.ts
src/lib/getSettingsPeroid.ts
src/pages/CreateAlert/styles.ts
src/store/actions/logs/addToSelectedField.ts
src/store/actions/trace/selectTraceFilter.ts
src/store/actions/trace/updateTagsSelected.ts
src/types/api/alerts/queryType.ts
src/types/api/dashboard/shared.ts
src/types/api/logs/operator.ts
src/types/api/logs/removeSelectedField.ts
src/types/api/user/setUserPreference.ts
src/typings/environment.ts
src/typings/window.ts
src/utils/fixtures/TraceData.ts
src/utils/token.ts

The results seem pretty accurate, but I'm not 100% sure about each file separately. For instance, I see some

styles.ts

files that are not imported anywhere, but they may be automatically included by a framework or build? If so, we can ignore such files and add them to the

filePatterns

with

!**/styles.ts

, and so on. Running the tool without the

--onlyFiles

View count: 3