GitHub
05/27/2023, 3:50 AMGitHub
05/28/2023, 2:40 PMGitHub
05/28/2023, 3:01 PMGitHub
05/29/2023, 1:34 AMimage▾
GitHub
05/29/2023, 11:57 AMGitHub
05/29/2023, 12:55 PMGitHub
05/29/2023, 1:00 PM<https://github.com/SigNoz/signoz/tree/develop|develop>
by pranay01
<https://github.com/SigNoz/signoz/commit/fdbb8b652e2ca7e1c107a54059f66f81cbd8c0ea|fdbb8b65>
- Nit: fix typo in install script. (#2793)
SigNoz/signozGitHub
05/29/2023, 1:00 PMGitHub
05/29/2023, 3:56 PMdeploy/installer.sh
because that script blocks for user input. Using deploy/installer.sh
in automations would be very valuable. See #1015.
Thank you SigNoz maintainers for this awesome project!
SigNoz/signoz
GitHub Actions: playwright
GitHub Actions: Ensure Pull Request has a linked issue.
GitHub Actions: lint-commits
✅ 8 other checks have passed
8/11 successful checksGitHub
05/30/2023, 12:20 AM<https://github.com/SigNoz/signoz/tree/develop|develop>
by pranay01
<https://github.com/SigNoz/signoz/commit/eb1c5c4565837de6bd2cefc429f61687def90cdb|eb1c5c45>
- fix: typo in contribution guide (#2792)
SigNoz/signozGitHub
05/30/2023, 12:20 AMGitHub
05/30/2023, 5:14 AMGitHub
05/30/2023, 7:24 AMUnexpected transport closing: too many pings from client
We've noticed this issue on Java-based services:
[otel.javaagent 2023-05-30 06:20:13:532 +0000] [OkHttp <http://otlp.dev:4317/...>] ERROR io.opentelemetry.exporter.internal.okhttp.OkHttpExporter - Failed to export metrics. The request could not be executed. Full error message: Connection reset
[otel.javaagent 2023-05-30 06:20:26:458 +0000] [OkHttp <http://otlp.dev:4317/...>] ERROR io.opentelemetry.exporter.internal.okhttp.OkHttpExporter - Failed to export spans. The request could not be executed. Full error message: Connection reset
[otel.javaagent 2023-05-30 06:20:41:467 +0000] [OkHttp <http://otlp.dev:4317/...>] ERROR io.opentelemetry.exporter.internal.okhttp.OkHttpExporter - Failed to export spans. The request could not be executed. Full error message: Connection reset
[otel.javaagent 2023-05-30 06:21:01:478 +0000] [OkHttp <http://otlp.dev:4317/...>] ERROR io.opentelemetry.exporter.internal.okhttp.OkHttpExporter - Failed to export spans. The request could not be executed. Full error message: Connection reset
We're using https://github.com/open-telemetry/opentelemetry-java-instrumentation to collect and send telemetry data for Java services.
image▾
GitHub
05/30/2023, 7:44 AMGitHub
05/30/2023, 8:15 AMGitHub
05/30/2023, 8:25 AMGitHub
05/30/2023, 8:31 AMGitHub
05/30/2023, 9:16 AMGitHub
05/30/2023, 9:50 AMdataFormatter.Format(82854982, "bytes") = 83MB
Why do we need both a converter and a formatter?
The formatter simply humanizes the value. This is usually the value from the ClickHouse query output. The converter comes into the picture when the threshold is involved. The user sees the chart with 300 MB (Y-Axis) but wants to set the threshold to 2 GB, so we need to convert the 2 GB into MB for comparison. These two will be seen in practice in follow up draft PR.
SigNoz/signoz
GitHub Actions: playwright
✅ 8 other checks have passed
8/9 successful checksGitHub
05/30/2023, 12:29 PMGitHub
05/30/2023, 3:23 PM<https://github.com/SigNoz/signoz/tree/develop|develop>
by palashgdev
<https://github.com/SigNoz/signoz/commit/bc5862646dc6d30d4c0d1741273d3c2df321daf9|bc586264>
- fix: where clause filter (#2800)
SigNoz/signozGitHub
05/30/2023, 3:23 PMGitHub
05/30/2023, 5:17 PMGitHub
05/31/2023, 5:55 AMGitHub
05/31/2023, 5:57 AM<https://github.com/SigNoz/signoz/tree/develop|develop>
by makeavish
<https://github.com/SigNoz/signoz/commit/26a806a7fe1c6074613eb7de8d3e781b135eff65|26a806a7>
- fix: mutex lock to avoid concurrent map writes (#2796)
SigNoz/signozGitHub
05/31/2023, 5:57 AMfatal error: concurrent map writes
goroutine 1016 [running]:
runtime.throw({0x14ee399?, 0x199?})
/usr/local/go/src/runtime/panic.go:992 +0x71 fp=0xc00546d070 sp=0xc00546d040 pc=0x43a731
runtime.mapassign_faststr(0xc000488000?, 0xc000488240?, {0x14eb0c2, 0x13})
/usr/local/go/src/runtime/map_faststr.go:212 +0x39c fp=0xc00546d0d8 sp=0xc00546d070 pc=0x4155fc
<http://go.signoz.io/signoz/pkg/query-service/telemetry.(*Telemetry).SendEvent(0xc0000f6420|go.signoz.io/signoz/pkg/query-service/telemetry.(*Telemetry).SendEvent(0xc0000f6420>, {0x14eb0c2, 0x13}, 0xa?, {0xc00546d337?, 0x12fa220?, 0xc0003ed358?})
/go/src/github.com/signoz/signoz/pkg/query-service/telemetry/telemetry.go:312 +0x18e fp=0xc00546d2f8 sp=0xc00546d0d8 pc=0xedbace
<http://go.signoz.io/signoz/ee/query-service/app.extractDashboardMetaData({0x14f6ad6|go.signoz.io/signoz/ee/query-service/app.extractDashboardMetaData({0x14f6ad6>, 0x1b}, 0xc00183d600)
/go/src/github.com/signoz/signoz/ee/query-service/app/server.go:353 +0x36c fp=0xc00546d390 sp=0xc00546d2f8 pc=0x10e34ac
<http://go.signoz.io/signoz/ee/query-service/app.(*Server).analyticsMiddleware.func1({0x18f6160|go.signoz.io/signoz/ee/query-service/app.(*Server).analyticsMiddleware.func1({0x18f6160>?, 0xc0007b7aa0}, 0xdf8475801?)
/go/src/github.com/signoz/signoz/ee/query-service/app/server.go:378 +0xa5 fp=0xc00546d698 sp=0xc00546d390 pc=0x10e3785
net/http.HandlerFunc.ServeHTTP(0x18f6518?, {0x18f6160?, 0xc0007b7aa0?}, 0x1b?)
/usr/local/go/src/net/http/server.go:2084 +0x2f fp=0xc00546d6c0 sp=0xc00546d698 pc=0x6ee78f
<http://go.signoz.io/signoz/ee/query-service/app.setTimeoutMiddleware.func1({0x18f6160|go.signoz.io/signoz/ee/query-service/app.setTimeoutMiddleware.func1({0x18f6160>, 0xc0007b7aa0}, 0xc00183d500)
/go/src/github.com/signoz/signoz/ee/query-service/app/server.go:410 +0x2f6 fp=0xc00546d748 sp=0xc00546d6c0 pc=0x10e3f36
net/http.HandlerFunc.ServeHTTP(0xc00183d400?, {0x18f6160?, 0xc0007b7aa0?}, 0xc000a0d610?)
/usr/local/go/src/net/http/server.go:2084 +0x2f fp=0xc00546d770 sp=0xc00546d748 pc=0x6ee78f
<http://github.com/gorilla/mux.(*Router).ServeHTTP(0xc0009500c0|github.com/gorilla/mux.(*Router).ServeHTTP(0xc0009500c0>, {0x18f6160, 0xc0007b7aa0}, 0xc00183d300)
/go/pkg/mod/github.com/gorilla/mux@v1.8.0/mux.go:210 +0x1cf fp=0xc00546d898 sp=0xc00546d770 pc=0x77a22f
<http://github.com/rs/cors.(*Cors).Handler.func1({0x18f6160|github.com/rs/cors.(*Cors).Handler.func1({0x18f6160>, 0xc0007b7aa0}, 0xc00183d300)
/go/pkg/mod/github.com/rs/cors@v1.8.2/cors.go:231 +0x1c4 fp=0xc00546d8f0 sp=0xc00546d898 pc=0x7aeb04
net/http.HandlerFunc.ServeHTTP(0x0?, {0x18f6160?, 0xc0007b7aa0?}, 0xc000a0d5e0?)
/usr/local/go/src/net/http/server.go:2084 +0x2f fp=0xc00546d918 sp=0xc00546d8f0 pc=0x6ee78f
<http://github.com/gorilla/handlers.CompressHandlerLevel.func1({0x18f5200|github.com/gorilla/handlers.CompressHandlerLevel.func1({0x18f5200>?, 0xc00094c1c0}, 0xc00183d300)
/go/pkg/mod/github.com/gorilla/handlers@v1.5.1/compress.go:141 +0x663 fp=0xc00546da70 sp=0xc00546d918 pc=0x779103
net/http.HandlerFunc.ServeHTTP(0x0?, {0x18f5200?, 0xc00094c1c0?}, 0x40f645?)
/usr/local/go/src/net/http/server.go:2084 +0x2f fp=0xc00546da98 sp=0xc00546da70 pc=0x6ee78f
net/http.serverHandler.ServeHTTP({0x18f0dd0?}, {0x18f5200, 0xc00094c1c0}, 0xc00183d300)
/usr/local/go/src/net/http/server.go:2916 +0x43b fp=0xc00546db58 sp=0xc00546da98 pc=0x6f1d7b
net/http.(*conn).serve(0xc0000d0b40, {0x18f6518, 0xc0006563c0})
/usr/local/go/src/net/http/server.go:1966 +0x5d7 fp=0xc00546dfb8 sp=0xc00546db58 pc=0x6ed237
net/http.(*Server).Serve.func3()
/usr/local/go/src/net/http/server.go:3071 +0x2e fp=0xc00546dfe0 sp=0xc00546dfb8 pc=0x6f26ce
runtime.goexit()
/usr/local/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc00546dfe8 sp=0xc00546dfe0 pc=0x46d881
created by net/http.(*Server).Serve
/usr/local/go/src/net/http/server.go:3071 +0x4db
Full log file of failure: signoz-query-service-concurrent-map-write.log
SigNoz/signozGitHub
05/31/2023, 5:57 AMGitHub
05/31/2023, 7:15 AMGitHub
05/31/2023, 10:24 AMGitHub
05/31/2023, 12:25 PM